Update stop market order liquidity warning + params #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanDYDX
reviewed
Apr 24, 2024
src/commonMain/kotlin/exchange.dydx.abacus/calculator/TradeInputCalculator.kt
Outdated
Show resolved
Hide resolved
| "code": "STOP_MARKET_ORDER_MAY_NOT_EXECUTE" | ||
| } | ||
| ] | ||
| "errors": null |
There was a problem hiding this comment.
[q] is this supposed to be an unhappy path test? if so should we change the test input params to ensure this still throws an error?
There was a problem hiding this comment.
eh it wasn't really an unhappy path - it was just a warning (non blocking for a user; errors are blocking) that we ripped out. I think I'm fine leaving it like this for now; we could add a test for SELL_TRIGGER_TOO_CLOSE_TO_LIQUIDATION_PRICE but I didn't touch that logic (and the mock data doesn't currently have a liquidation price) so inclined to leave it like this for now!
prashanDYDX
approved these changes
Apr 24, 2024
moo-onthelawn
deleted the
mulan/ct-779-remove-warning-for-users-placing-stop-market-orders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per product, update stop market slippages from:
For cleanliness, updated constants to be shared between
TriggerOrdersInputCalculatorandTradeInputCalculator; removed unusedMARKET_ORDER_SLIPPAGE_WARNING_THRESHOLD.Also remove
STOP_MARKET_ORDER_MAY_NOT_EXECUTEwarning prompting users to use stop limit orders.