Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics: add missing fields in place/cancel order events #301

Merged
merged 4 commits into from
Apr 11, 2024
Merged

analytics: add missing fields in place/cancel order events #301

merged 4 commits into from
Apr 11, 2024

Conversation

aforaleka
Copy link
Contributor

  • for cancel events, add more details from order
  • for place order click, infer time in force based on v4-clients helper function, since payload's original time in force can be null

@aforaleka aforaleka force-pushed the add-missing-fields-to-analytics branch 2 times, most recently from 4168066 to 886f887 Compare April 11, 2024 17:53
@aforaleka aforaleka force-pushed the add-missing-fields-to-analytics branch from 886f887 to 0e03c30 Compare April 11, 2024 19:17
@aforaleka aforaleka force-pushed the add-missing-fields-to-analytics branch from 0e03c30 to 7bcdacb Compare April 11, 2024 19:18
@aforaleka aforaleka merged commit 2cb681a into main Apr 11, 2024
2 checks passed
@aforaleka aforaleka deleted the add-missing-fields-to-analytics branch April 11, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aforaleka @ruixhuang