Use correct side for position notifications. (#716)

dydxprotocol · Oct 18, 2024 · cde9fd2 · cde9fd2
1 parent 87df8d9
commit cde9fd2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/commonMain/kotlin/exchange.dydx.abacus/output/input/TradeInput.kt b/src/commonMain/kotlin/exchange.dydx.abacus/output/input/TradeInput.kt
@@ -783,6 +783,11 @@ enum class OrderSide(val rawValue: String) {
     Buy("BUY"),
     Sell("SELL");
 
+    fun opposite() = when (this) {
+        Buy -> Sell
+        Sell -> Buy
+    }
+
     companion object {
         operator fun invoke(rawValue: String?) =
             OrderSide.values().firstOrNull { it.rawValue == rawValue }

diff --git a/...in/exchange.dydx.abacus/state/manager/notification/providers/FillsNotificationProvider.kt b/...in/exchange.dydx.abacus/state/manager/notification/providers/FillsNotificationProvider.kt
@@ -156,8 +156,11 @@ class FillsNotificationProvider(
         val asset = stateMachine.state?.assetOfMarket(marketId) ?: return null
         val assetText = asset.name
         val marketImageUrl = asset.resources?.imageUrl
-        val side = fill.side.rawValue
+
+        // opposite because these notifications are all about positions, not the fill that triggered the notif.
+        val side = fill.side.opposite().rawValue
         val sideText = uiImplementations.localizer?.localize("APP.GENERAL.$side")
+
         val amountText = parser.asString(fill.size)
         val priceText = parser.asString(fill.price)
         val fillType = fill.type.rawValue