Revert "fix: vaults submission types match better (#676)"

This reverts commit 45570fe.
dydxprotocol · Sep 25, 2024 · 8295fff · 8295fff
1 parent 45570fe
commit 8295fff
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 18 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -52,7 +52,7 @@ allprojects {
 }
 
 group = "exchange.dydx.abacus"
-version = "1.11.20"
+version = "1.11.19"
 
 repositories {
     google()

diff --git a/src/commonMain/kotlin/exchange.dydx.abacus/functional/vault/VaultDepositWithdrawForm.kt b/src/commonMain/kotlin/exchange.dydx.abacus/functional/vault/VaultDepositWithdrawForm.kt
@@ -1,6 +1,5 @@
 package exchange.dydx.abacus.functional.vault
 
-import com.ionspin.kotlin.bignum.decimal.toBigDecimal
 import exchange.dydx.abacus.output.input.ErrorFormat
 import exchange.dydx.abacus.output.input.ErrorParam
 import exchange.dydx.abacus.output.input.ErrorResources
@@ -166,15 +165,15 @@ data class VaultDepositWithdrawSubmissionData(
 @Serializable
 data class VaultDepositData(
     val subaccountFrom: String,
-    val quoteQuantums: String
+    val amount: Double
 )
 
 @JsExport
 @Serializable
 data class VaultWithdrawData(
     val subaccountTo: String,
-    val shares: String,
-    val minQuoteQuantums: String,
+    val shares: Double,
+    val minAmount: Double
 )
 
 @JsExport
@@ -202,9 +201,7 @@ object VaultDepositWithdrawFormValidator {
 
     private const val SLIPPAGE_PERCENT_WARN = 0.01
     private const val SLIPPAGE_PERCENT_ACK = 0.04
-    private const val EXTRA_SLIPPAGE_TOLERANCE = 0.01
-
-    private const val QUANTUMS_MULTIPLIER = 1_000_000
+    private const val SLIPPAGE_TOLERANCE = 0.01
 
     fun getVaultDepositWithdrawSlippageResponse(apiResponse: String): VaultDepositWithdrawSlippageResponse? {
         return parser.asTypedObject<VaultDepositWithdrawSlippageResponse>(apiResponse)
@@ -334,7 +331,7 @@ object VaultDepositWithdrawFormValidator {
                 VaultFormAction.DEPOSIT -> VaultDepositWithdrawSubmissionData(
                     deposit = VaultDepositData(
                         subaccountFrom = "0",
-                        quoteQuantums = amount.toBigDecimal().times(QUANTUMS_MULTIPLIER).toBigInteger().toString(),
+                        amount = amount,
                     ),
                     withdraw = null,
                 )
@@ -343,10 +340,8 @@ object VaultDepositWithdrawFormValidator {
                     withdraw = if (sharesToAttemptWithdraw != null && sharesToAttemptWithdraw > 0 && slippageResponse != null) {
                         VaultWithdrawData(
                             subaccountTo = "0",
-                            shares = sharesToAttemptWithdraw.toBigDecimal().toBigInteger().toString(),
-                            minQuoteQuantums = (slippageResponse.expectedAmount * (1 - EXTRA_SLIPPAGE_TOLERANCE)).toBigDecimal().times(
-                                QUANTUMS_MULTIPLIER,
-                            ).toBigInteger().toString(),
+                            shares = sharesToAttemptWithdraw,
+                            minAmount = slippageResponse.expectedAmount * (1 - SLIPPAGE_TOLERANCE),
                         )
                     } else {
                         null

diff --git a/src/commonTest/kotlin/exchange.dydx.abacus/functional/vault/VaultFormTests.kt b/src/commonTest/kotlin/exchange.dydx.abacus/functional/vault/VaultFormTests.kt
@@ -1,6 +1,5 @@
 package exchange.dydx.abacus.functional.vault
 
-import com.ionspin.kotlin.bignum.decimal.toBigDecimal
 import exchange.dydx.abacus.output.input.ValidationError
 import kollections.iListOf
 import kollections.toIList
@@ -49,7 +48,7 @@ class VaultFormTests {
                 submissionData = VaultDepositWithdrawSubmissionData(
                     deposit = VaultDepositData(
                         subaccountFrom = "0",
-                        quoteQuantums = "100000000",
+                        amount = 100.0,
                     ),
                     withdraw = null,
                 ),
@@ -100,8 +99,8 @@ class VaultFormTests {
                     deposit = null,
                     withdraw = VaultWithdrawData(
                         subaccountTo = "0",
-                        shares = "100",
-                        minQuoteQuantums = (98 * .99).toBigDecimal().times(1000000).toBigInteger().toString(),
+                        shares = 100.0,
+                        minAmount = 98 * .99,
                     ),
                 ),
                 summaryData = VaultFormSummaryData(

diff --git a/v4_abacus.podspec b/v4_abacus.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |spec|
     spec.name                     = 'v4_abacus'
-    spec.version                  = '1.11.20'
+    spec.version                  = '1.11.19'
     spec.homepage                 = 'https://github.com/dydxprotocol/v4-abacus'
     spec.source                   = { :http=> ''}
     spec.authors                  = ''