Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize comments, variables, etc. #121

Merged
merged 15 commits into from
Dec 28, 2020
Merged

Normalize comments, variables, etc. #121

merged 15 commits into from
Dec 28, 2020

Conversation

richburdon
Copy link
Member

@richburdon richburdon commented Dec 20, 2020

Prep for #120 and dxos/console#67

To discuss:

  • why are only some extensions listed in known-extensions (which data is in this, vs local yml, vs code)?
  • cert (why on root CLI)
  • forward, mnemonic?
  • service (what is this? document)
  • machine => kube?
  • wns => registry
  • peer => merge with mesh
  • halo extension (merge with profile?)
  • ~/.wire config (migration)
  • Typescript (lint)

Moved to: #126

Copy link
Contributor

@egorgripasov egorgripasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richburdon We should discuss URL schema changes, and ideally @ashwinphatak and @telackey should also be a part of that discussion.

Main points:

  1. Current schema supports arbitrary number of "subfolders", e.g. wrn://dxos/testing/application/egor/arena is a valid app wrn. Question: do we want to restrict to authority:path (e.g. dxos:application)?
  2. wrns in app url are urlencoded, because of (1) - because we need to distinguish between wrn itself and file path, e.g. url_encode('wrn://dxos/testing/application/egor/arena')/path/to/file.js
  3. Path like dxos:application/console@alpha:service_worker.js not gonna work for bundle files
  4. Changes should be backward compatible since migration will take time and would happen on different level of the system.

Comment on lines 111 to 118
//
// Router handler.
// Example: dxos:application/console@alpha:service_worker.js
//
const appFileHandler = async (req, res) => {
const route = req.params[0];
const [authority, path, file = '/'] = route.split(':');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite artificial for apps, since typically index.html would contain a list of files to use (css, js, ico, etc), so regular GET requests for bundle files would not work that way.

Also, changes like that should be introduced in backward-compatible way, since those convention is used in many places throughout the org, so we can not switch instantly.

@richburdon richburdon merged commit 2c3752e into main Dec 28, 2020
@richburdon richburdon deleted the burdon/normalize branch December 28, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants