-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize comments, variables, etc. #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richburdon We should discuss URL schema changes, and ideally @ashwinphatak and @telackey should also be a part of that discussion.
Main points:
- Current schema supports arbitrary number of "subfolders", e.g.
wrn://dxos/testing/application/egor/arena
is a valid app wrn. Question: do we want to restrict toauthority:path
(e.g.dxos:application
)? - wrns in app url are urlencoded, because of (1) - because we need to distinguish between wrn itself and file path, e.g.
url_encode('wrn://dxos/testing/application/egor/arena')/path/to/file.js
- Path like
dxos:application/console@alpha:service_worker.js
not gonna work for bundle files - Changes should be backward compatible since migration will take time and would happen on different level of the system.
packages/cli-app/src/server.js
Outdated
// | ||
// Router handler. | ||
// Example: dxos:application/console@alpha:service_worker.js | ||
// | ||
const appFileHandler = async (req, res) => { | ||
const route = req.params[0]; | ||
const [authority, path, file = '/'] = route.split(':'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite artificial for apps, since typically index.html would contain a list of files to use (css, js, ico, etc), so regular GET requests for bundle files would not work that way.
Also, changes like that should be introduced in backward-compatible way, since those convention is used in many places throughout the org, so we can not switch instantly.
2362cb5
to
9b411c1
Compare
Prep for #120 and dxos/console#67
To discuss:
cert
(why on root CLI)forward
,mnemonic
?service
(what is this? document)machine
=>kube
?wns
=>registry
peer
=> merge withmesh
halo
extension (merge withprofile
?)~/.wire config
(migration)Moved to: #126