New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeReview #1

Open

aishcann wants to merge 1 commit into dwindleduck:main from aishcann:codeReview

aishcann commented Feb 13, 2023

do not merge this code

This is for you to look over and allows us to give direct feedback on your code in addition to a spreadsheet of more quantified grades

Below is a brief summary, if you compare changes you will see any comments I made in your code highlighted in each file

Glows:

code is organized and indented properly
nice, visually clear comments to indicate sections in code
nice use of semantic html

Grows:

you can benefit from leaving even more comments in your code, specifically for each function and naming what that function is doing

Great work!


          codeReview

fc0ccb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet