Move timestamps to CSS div:before statements #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #129
If @seconddayout is like me, the issue is with the YouTube video transcripts. Although it looks like one can select across <div>s...
...when Hypothesis grabs the text, it only gets the part in the first <div>:
I ran into this same sort of problem when I was creating an equivalent to droppdf for podcasts (see unchecked-transcript). To solve the problem, I put the timestamp into a CSS
:before
declaration. See this example for what it looks like in practice—notably the first Hypothesis annotation that crosses three <div>s.This pull request is my best guess at how this solution would work with droppdf. Unfortunately, I couldn't get all of the droppdf prerequisites to install on my machine, so I wasn't able to do an end-to-end test of the code changes.