-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove POA needles indexing #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed: `SubVectorXYZ`, `AddVectorXYZ`, `AddVector` and `SubVector` are not needed anymore Renamed: `MakePOA` to `NewPOA` Removed: Third argument of `getPieceOffset` wire not needed anymore Utilize: Vector `IsZero`
Hey, @Grocel With this modification I was able to remove the different indexing nonsense. The method |
Fixed: `POA:IsSame` inversed logic Added: More conversion methods to POA
Renamed: `Make~` to `New~` Renamed: `POA:Table` to `POA:Array`
Added: Addition class defaults to physics prop Renamed: Some local variables
… bodygroup/skin Replaced: Rest of "Make" with "New" Consolidated: `GetTerm` and `GetVacant`
This PR is big as it is intended to be. Next PR may remove |
Added: Dedicated function for disabled strings
Removed: Internal format values for `GetReport`
Added: Source model for errors importing POA
Added: Log control client-side in TM button
Fixed: Localizing `select` lua function
Fixed: Attachment ID to return extracted model second Fixed: Angle being updated to POA instead of the point Added: Extra log for model `X` when processing its attachments Changed: `Record not located` to `Error missing`
TODO: Test importing and exporting DSV
Fixed: Various runtime errors affecting `ExportTypeAR` Updated: Export DB manual mapped to right click
Fixed: Ghosts not being ignored by the duplication
Fixed: Timer attach and restart methods Fixed: Memory manager fail on one navigation step Fixed: Hook info returning empty toolin some cases Fixed: Ghosting now utilizes Fixed: Flip over remove errors during spawn and validation Added: Active tool validation in some hooks Updated: Database storage `CL/SV` to `LUA/SQL` Removed: Usage of Depricated STRING:Implode(TABLE) Removed: `TOOL:Deploy` as it is not needed anymore Removed: Usage of `oPly:GetNWBool(gsToolPrefL.."enghost")`
Fixed: Processing DSV generating table indexing errors Added: Use library unpack method for normal angle Added: Extra log on timer navigation fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use the vector and angle unpack method to basically transform
to become