-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): add jitsu #438
Conversation
Signed-off-by: duyet <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThe PR adds Jitsu analytics script alongside the existing Seline analytics in the documentation theme configuration. The implementation wraps both script tags in a React fragment to properly handle multiple elements in the head configuration. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief comment in the config file or PR description about the purpose of adding Jitsu analytics alongside Seline.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
<> | ||
<Script | ||
async | ||
src="https://cdn.seline.so/seline.js" | ||
data-token="05046b3773d0534" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Consider adding Subresource Integrity (SRI) checks for the external scripts
To prevent potential security issues from CDN compromises, add integrity attributes with appropriate hash values for both script tags.
<Script
async
src="https://cdn.seline.so/seline.js"
data-token="05046b3773d0534"
integrity="sha384-oqVuAfXRKap7fdgcCY5uykM6+R9GqQ8K/uxy9rx7HNQlGYl1kPzQho1wx4JwY8wC"
crossOrigin="anonymous"
/>
Summary by Sourcery
Documentation: