-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(running-queries): adjust position and styling of running queries #426
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis PR adjusts the layout and styling of running queries and chart tooltips. The changes focus on improving the visual presentation by reorganizing flex layouts and adjusting positioning of elements. Class diagram for updated chart tooltip layoutclassDiagram
class ChartTooltip {
- h: number
- w: number
- bg: string
- color: string
+ renderTooltip(name: string, index: number, item: object): JSX.Element
}
class ChartConfig {
+ label: string
}
ChartTooltip --> ChartConfig : uses
note for ChartTooltip "Updated flex layout and positioning for improved styling"
Class diagram for updated RunningQueries componentclassDiagram
class RunningQueries {
- className: string
+ render(): JSX.Element
}
class Card {
+ className: string
}
class CardContent {
+ className: string
}
RunningQueries --> Card : uses
Card --> CardContent : contains
note for RunningQueries "Adjusted position and styling of elements within the component"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Bundle ReportChanges will decrease total bundle size by 7.19kB (-0.11%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Using 'text-black' directly may cause issues with dark mode - consider using a theme-aware color token instead like the existing 'text-muted-foreground'
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
} as React.CSSProperties | ||
} | ||
/> | ||
<div className="flex flex-row"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider extracting the repeated color indicator box and label pattern into a reusable component
This would reduce code duplication and make future maintenance easier.
const ColorIndicator = ({ color, label }: { color: string; label: string }) => (
<div className="flex flex-row items-center gap-2">
<div className={`h-2.5 w-2.5 shrink-0 rounded-[2px] bg-[${color}]`} />
<span>{label}</span>
</div>
);
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 5 5
Lines 157 157
Branches 57 58 +1
=======================================
Hits 123 123
+ Misses 34 31 -3
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Bug Fixes: