forked from osbuild/osbuild
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CoreOS oci-archive input example #12
Open
lukewarmtemp
wants to merge
11
commits into
dustymabe:main
Choose a base branch
from
lukewarmtemp:coreos-oci-archive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the aleph file created for builds of FCOS based on ostree commit inputs, this adds an aleph file builds based on container image inputs.
the container image metadata
Fixes some of the labels in the aleph file. Calling `ostree container image metadata` also requires the target image reference to be only the container image and tag (ie. without the signature verification type and remote).
Apply key sorting when using `json.dump`. Prevent double dict query and string buffer creation.
Refactor the code in the deploy stage to create a separate aleph stage. A new stage prefered as both the org.osbuild.ostree.deploy and org.osbuild.ostree.deploy.container stages need an aleph file. Aleph files are also a coreos specific feature, which is why a separate stage is beneficial.
Create a symlink between the `.aleph-version.json` and `.coreos-aleph-version.json` files to allow for backward compatibility with CoreOS.
This commit allows the target imgref to be found automatically from the deployment root's origin file. If the deployment is not specified in the mpp.yaml file, this stage will be able to populate the aleph file on the assumption that there is only one deployment.
This commit makes the code more clear by refactoring the part extracts the deployment type and imgref from the origin file into a separate function. This function was implemented as an ostree tool such that other stages can also utilize it. Several other minor changes were also made to clean up the code
Create a new mpp.yaml file that uses the org.osbuild.copy stage to copy an ociarchive to a previous pipeline. The oci-archive can then be used as an input to the org.ostree.deploy.container stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.