Refactor the HTTP handler into a struct

[jameinel]

This changes the 'handler' from being just a func() using global state to being a struct with local state.
It then moves the things like dev and log to being members of the struct, with interfaces that let us override them in the test suite.
It then adds a bunch of tests about how we handle failures, errors, logging, the size flag, etc.
The interfaces also mean that we won't try to spam syslog while running the test suite.

Another small change is that if you do:

    pollen -https-port=""

Then it won't try to bind to the HTTP port with a cert.
Since I'm not the official source for pollen, it helped for testing at least the HTTP requests manually.

This also fixes the help text for "-size" since it doesn't actually change how much content we send on the wire, but how much content we read from /dev/urandom (but it adds tests for that fact).

[dustinkirkland]

Looks brilliant, thanks!

Committed and pushed to both bzr and git.

kirkland@x230:~/src/pollen/pollen⟫ debcommit
bzr commit -m '* .gitignore, pollen.go, pollen_test.go:

• This changes the 'handler' from being just a func() using global
  state to being a struct with local state.
• It then moves the things like dev and log to being members of the
  struct, with interfaces that let us override them in the test suite.
• It then adds a bunch of tests about how we handle failures, errors,
  logging, the size flag, etc.
• The interfaces also mean that we won't try to spam syslog while running
  the test suite.
• Another small change is that if you do:
  pollen -https-port=""
  Then it won't try to bind to the HTTP port with a cert.
• Since I'm not the official source for pollen, it helped for testing at
  least the HTTP requests manually.
• This also fixes the help text for "-size" since it doesn't actually
  change how much content we send on the wire, but how much content we
  read from /dev/urandom (but it adds tests for that fact).'
  Committing to: /home/local/media/source/pollen/pollen/

added .gitignore
modified pollen.go
modified pollen_test.go
modified debian/changelog
Committed revision 272.
kirkland@x230:~/src/pollen/pollen⟫ multi-push
INFO: bzr exists
Using saved push location: bzr+ssh://bazaar.launchpad.net/+branch/pollen/
Pushed up to revision 272.

INFO: git exists
10:30:21 Calculating the revisions to include ...
10:30:21 Starting export of 286 revisions ...
10:30:21 Exported 286 revisions in 0:00:00
warning: push.default is unset; its implicit value is changing in
Git 2.0 from 'matching' to 'simple'. To squelch this message
and maintain the current behavior after the default changes, use:

git config --global push.default matching

To squelch this message and adopt the new behavior now, use:

git config --global push.default simple

See 'git help config' and search for 'push.default' for further information.
(the 'simple' mode was introduced in Git 1.7.11. Use the similar mode
'current' instead of 'simple' if you sometimes use older versions of Git)

Counting objects: 12, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (7/7), 5.63 KiB | 0 bytes/s, done.
Total 7 (delta 5), reused 3 (delta 1)
To [email protected]:dustinkirkland/pollen.git
f3a684b..f026a08 master -> master

Dustin Kirkland
Canonical, Ltd.

On Wed, Feb 26, 2014 at 3:06 AM, John Arbash Meinel <
[email protected]> wrote:

This changes the 'handler' from being just a func() using global state to
being a struct with local state.
It then moves the things like dev and log to being members of the struct,
with interfaces that let us override them in the test suite.
It then adds a bunch of tests about how we handle failures, errors,
logging, the size flag, etc.
The interfaces also mean that we won't try to spam syslog while running
the test suite.

Another small change is that if you do:

pollen -https-port=""

Then it won't try to bind to the HTTP port with a cert.
Since I'm not the official source for pollen, it helped for testing at
least the HTTP requests manually.

This also fixes the help text for "-size" since it doesn't actually change
how much content we send on the wire, but how much content we read from

/dev/urandom (but it adds tests for that fact).

You can merge this Pull Request by running

git pull https://github.com/jameinel/pollen struct-refactor

Or view, comment on, or merge it at:

#6
Commit Summary

• Move the handler into a struct
• Move the dev object as an io.ReadWriter attribute of the server
• abstract the logging behind an interface
• fix the size help text
• allow disabling https-port or http-port by passing ""
• allow disabling https-port or http-port by passing ""
• go fmt and test with canned data
• Assert that changing the size actually changes how the backend works.
• more error message testing

File Changes

• A .gitignorehttps://github.com/Refactor the HTTP handler into a struct #6/files#diff-0(1)
• M pollen.gohttps://github.com/Refactor the HTTP handler into a struct #6/files#diff-1(101)
• M pollen_test.gohttps://github.com/Refactor the HTTP handler into a struct #6/files#diff-2(232)

Patch Links:

• https://github.com/dustinkirkland/pollen/pull/6.patch
• https://github.com/dustinkirkland/pollen/pull/6.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6
.