Update set_allowed_admin_auth_methods in admin.py #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the changes in the following PRs: https://github.com/cisco-sbg/ZT-trustedpath/pull/15397/files https://github.com/cisco-sbg/ZT-trustedpath/pull/16174/files We need to update the file third-party/duo_client_python/project/duo_client/admin.py in duo_client_python as well. Ticket: https://cisco-sbg.atlassian.net/browse/ZTAEX-985
spencermaxfield
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the changes in the following PRs in file
third-party/duo_client_python/project/duo_client/admin.py:We need to update the file
duo_client/admin.pyin duo_client_python as well.Ticket: https://cisco-sbg.atlassian.net/browse/ZTAEX-985
Motivation and Context
After the feature has gone GA, we should add the verified push setting to the duo client repo to ensure Kit can control it from duo_client_python
How Has This Been Tested?
All existing Admin tests should pass.
Types of Changes