Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pancakeswapx on arbitrum to dex trades #7428

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Add pancakeswapx on arbitrum to dex trades #7428

merged 8 commits into from
Jan 9, 2025
+85 −20

Conversation

ChefButterBeer
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Add pancakeswapx on arbitrum to dex trades

quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 7, 2025 10:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 7, 2025
@ChefButterBeer
Copy link
Contributor Author

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

@ChefButterBeer
Copy link
Contributor Author

Pull Request Comment same as the below format.
recheck

@ChefButterBeer
Copy link
Contributor Author

recheck

@ChefButterBeer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ChefButterBeer
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Jan 7, 2025
@github-actions
@ChefButterBeer has signed the CLA in #7428
3035681
@ChefButterBeer ChefButterBeer marked this pull request as ready for review January 7, 2025 10:42
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 7, 2025
@Hosuke Hosuke self-assigned this Jan 7, 2025
Hosuke
Hosuke approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @ChefButterBeer

Sample pcsx pancakeswap_v2_arbitrum_base_trades

@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 9, 2025
@jeff-dude jeff-dude merged commit 3e264a4 into duneanalytics:main Jan 9, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

@Hosuke Hosuke Hosuke approved these changes

Assignees

@Hosuke Hosuke

Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChefButterBeer @Hosuke @jeff-dude