Aave v2/v3 lending.supply macro fix - add WrappedTokenGateway lookup
#7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
github-actions
bot
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
Current logic for withdrawals on Aave v2/v3 defaults
withdrawn_totoWrappedTokenGatewaycontract address, but doesn't show lender's address. This PR aims to fix this and output lender's address inon_behalf_ofcolumn (currentlynull).Note: not all Aave forks use
WrappedTokenGatewaycontract address in their implementation of the protocol, so this fix is applied only to Aave for the time being. Forks can be revisited later on.quick links for more information: