feat: expose paraswap v6 decoded trades #7359
Open
+41
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
github-actions
bot
added
ready-for-review
Hosuke
requested changes
Dec 19, 2024
Comment on lines
10
to
13
| post_hook='{{ expose_spells(\'["arbitrum"]\', | ||
| "project", | ||
| "paraswap_v6", | ||
| \'["eptighte", "mwamedacen"]\') }}' |
There was a problem hiding this comment.
We can apply the new format for post_hooks:
Suggested change
| post_hook='{{ expose_spells(\'["arbitrum"]\', | |
| "project", | |
| "paraswap_v6", | |
| \'["eptighte", "mwamedacen"]\') }}' | |
| post_hook='{{ expose_spells(blockchains = \'["arbitrum"]\', | |
| spell_type = "project", | |
| spell_name = "paraswap_v6", | |
| contributors = \'["eptighte", "mwamedacen"]\') }}' |
There was a problem hiding this comment.
hey @Hosuke ,
i've tried to apply this new verbose format but I'm getting this compilation error now
I've checked configs and we're not using the deprecated field "tests" and use "data_tests" instead.
Do you know what might be the cause?
Hosuke
added
in review
…o feat/expose-paraswap-v6-decoded-trades
|
please merge in |
…o feat/expose-paraswap-v6-decoded-trades
This reverts commit bbca115.
That worked, thank you. Is all good to merge then? |
Hosuke
approved these changes
Dec 23, 2024
Hosuke
added
ready-for-merging
and removed
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Expose ParaSwap v6 decoded trades