feat: add katana v3 dex ronin #7354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
github-actions
bot
added
ready-for-review
|
@Hosuke can you check this please SELECT * FROM katana_dex_ronin.KatanaPair_evt_Swap
LIMIT 1 |
Hosuke
reviewed
Dec 19, 2024
Comment on lines
4
to
7
| - name: katana_v2_dex_ronin | ||
| tables: | ||
| - name: KatanaPair_evt_Swap | ||
| - name: KatanaFactory_evt_PairCreated No newline at end of file | ||
| - name: KatanaFactory_evt_PairCreated |
There was a problem hiding this comment.
We need to make sure the source here match the name in dune.
There was a problem hiding this comment.
Thank you so much!
Should be solved now!
fix source not found
add line break
Hosuke
requested changes
Dec 19, 2024
dbt_subprojects/dex/seeds/trades/katana_v3_ronin_base_trades_seed.csv
Outdated
Show resolved
Hide resolved
Hosuke
added
in review
Hosuke
added
ready-for-merging
and removed
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
quick links for more information: