Saddle Finance DEX on Optimism Chain #7282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRobin
added
ready-for-review
Hosuke
requested changes
Dec 10, 2024
| materialized = 'incremental', | ||
| file_format = 'delta', | ||
| incremental_strategy = 'merge', | ||
| unique_key = ['block_date', 'blockchain', 'project', 'version', 'tx_hash', 'evt_index'] |
There was a problem hiding this comment.
Suggested change
| unique_key = ['block_date', 'blockchain', 'project', 'version', 'tx_hash', 'evt_index'] | |
| unique_key = ['tx_hash', 'evt_index'] |
Comment on lines
588
to
589
| filter: | ||
| version: 2 |
There was a problem hiding this comment.
Suggested change
| filter: | |
| version: 2 |
Hosuke
added
in review
|
Please run |
Hosuke
approved these changes
Dec 17, 2024
Hosuke
added
ready-for-final-review
and removed
in review
jeff-dude
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: