-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimism: uniswap pools dex balances #7271
base: main
Are you sure you want to change the base?
Conversation
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
...bprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/op_token_balances.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/schema.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/schema.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/_sector/stablecoins/Opitimism/Uniswap/schema.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/_sector/dex/pools/optimism/uniswap/_sources.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/_sector/dex/pools/optimism/uniswap/_sources.yml
Outdated
Show resolved
Hide resolved
dbt_subprojects/daily_spellbook/models/_sector/dex/pools/optimism/uniswap/_sources.yml
Outdated
Show resolved
Hide resolved
tables: | ||
- name: UniswapV3Factory_evt_PoolCreated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm second guessing myself a bit now, after seeing this moved here. since uniswap_v3_optimism
schema is called out but no tables specifically, i think it already accounts for all tables under that schema automatically. i'm afraid if we add this table specifically, it could break other models that relied on the auto assignment of all tables under that schema.
last check, can you remove this table completely (i.e. lines 5 & 6), and just let it run with only the schema there? would like to see if CI is able to run fine in that setup.
also do help me confirm if you are sticking with this decoded table vs. switching to the other spell of pools mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your guidance! I’ve decided to switch to using the uniswap_optimism_pools spell instead of the decoded table. This approach aligns better with the existing structure and ensures consistency across models.
I also ran CI without adding the table explicitly under sources, relying only on the schema, but an error occurred. Could you advise on what steps I should take next? Should I re-add the table explicitly, or is there another setup I should consider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm a bit confused. you mention moving to uniswap_optimism_pools
spell as a source, but still see the old decoded table in the PR now?
you will need to list spell as a source here:
https://github.com/duneanalytics/spellbook/blob/main/sources/_subprojects_outputs/dex/_sources.yml
then update your model to read from source('uniswap_optimism,' 'pools')
please merge in main to resolve the compile issue. |
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
[...]
quick links for more information: