Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimism: uniswap pools dex balances #7271

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Jason4276
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@0xRobin 0xRobin added WIP work in progress dbt: daily covers the Daily dbt subproject labels Dec 10, 2024
@0xRobin 0xRobin marked this pull request as draft December 10, 2024 12:18
@jeff-dude jeff-dude self-assigned this Dec 10, 2024
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed WIP work in progress labels Dec 10, 2024
@jeff-dude jeff-dude added the WIP work in progress label Dec 10, 2024
@jeff-dude jeff-dude changed the title uniswap dex balances optimism: uniswap pools dex balances Dec 11, 2024
Comment on lines 5 to 6
tables:
- name: UniswapV3Factory_evt_PoolCreated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm second guessing myself a bit now, after seeing this moved here. since uniswap_v3_optimism schema is called out but no tables specifically, i think it already accounts for all tables under that schema automatically. i'm afraid if we add this table specifically, it could break other models that relied on the auto assignment of all tables under that schema.

last check, can you remove this table completely (i.e. lines 5 & 6), and just let it run with only the schema there? would like to see if CI is able to run fine in that setup.

also do help me confirm if you are sticking with this decoded table vs. switching to the other spell of pools mentioned.

Copy link
Contributor Author

@Jason4276 Jason4276 Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your guidance! I’ve decided to switch to using the uniswap_optimism_pools spell instead of the decoded table. This approach aligns better with the existing structure and ensures consistency across models.

I also ran CI without adding the table explicitly under sources, relying only on the schema, but an error occurred. Could you advise on what steps I should take next? Should I re-add the table explicitly, or is there another setup I should consider?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm a bit confused. you mention moving to uniswap_optimism_pools spell as a source, but still see the old decoded table in the PR now?

you will need to list spell as a source here:
https://github.com/duneanalytics/spellbook/blob/main/sources/_subprojects_outputs/dex/_sources.yml

then update your model to read from source('uniswap_optimism,' 'pools')

@jeff-dude jeff-dude requested a review from 0xRobin December 17, 2024 18:51
@jeff-dude jeff-dude assigned 0xRobin and unassigned jeff-dude Dec 17, 2024
@Jason4276 Jason4276 marked this pull request as ready for review December 19, 2024 10:06
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Dec 19, 2024
@0xRobin
Copy link
Collaborator

0xRobin commented Dec 20, 2024

please merge in main to resolve the compile issue.

@0xRobin 0xRobin marked this pull request as draft December 20, 2024 09:50
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: daily covers the Daily dbt subproject in review Assignee is currently reviewing the PR WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants