Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init flare dex #7243

Merged
merged 60 commits into from
Jan 7, 2025
Merged

Init flare dex #7243

merged 60 commits into from
Jan 7, 2025

Conversation

Hosuke
Copy link
Collaborator

@Hosuke Hosuke commented Dec 5, 2024

Init flare dex

@Hosuke Hosuke added WIP work in progress dbt: dex covers the DEX dbt subproject labels Dec 5, 2024
@jeff-dude
Copy link
Member

thank you 🙏
i will send word back to the team on missing swap contracts

@jeff-dude jeff-dude self-assigned this Dec 5, 2024
Copy link
Contributor

@Yakuf Yakuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add too: (I didn't put commas!)
('phili-inu', 'PHIL', 0x932E691aA8c8306C4bB0b19F3f00a284371be8Ba,18)
('flare-inu', 'FINU', 0x2F8d7ff4f55D7B3E10D4910BeB38209291843B36, 18)

@jeff-dude
Copy link
Member

updates on decoded tables:

  • sparkdex uni v2 fork: sparkdex_flare.UniswapV2Factory_evt_PairCreated, event swaps approved and backfilling now
  • sparkdex uni v3 fork: sparkdex_flare.UniswapV3Factory_evt_PoolCreated, sparkdex_flare.UniswapV3Pool_evt_Swap
  • enosys uni v3 fork: already covered here
  • blazeswap uni v2 fork: blazeswap_flare.BlazeSwapFactory_evt_PairCreated, event swaps pending approval

@jeff-dude jeff-dude assigned jeff-dude and unassigned 0xRobin Jan 2, 2025
@jeff-dude
Copy link
Member

looks like only enosys v3 source is empty now. can you validate the data from my recent commits for enosys v2, to ensure correct?

@jeff-dude jeff-dude removed the question Further information is requested label Jan 2, 2025
@Hosuke
Copy link
Collaborator Author

Hosuke commented Jan 4, 2025

looks like only enosys v3 source is empty now. can you validate the data from my recent commits for enosys v2, to ensure correct?

enosys v2 base trades

I think that's correct.

@Hosuke Hosuke marked this pull request as ready for review January 4, 2025 20:02
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 4, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 6, 2025
@jeff-dude
Copy link
Member

@Hosuke let's prep this for merge. remove enosys v3, add back union of flare data into final dex trades, etc.

we will revisit enosys v3 in a follow up PR when ready

Hosuke added 2 commits January 6, 2025 23:51
- Remove enosys v3 model and its references
- Keep enosys v2, sparkdex v2/v3, and blazeswap in flare trades
@Hosuke
Copy link
Collaborator Author

Hosuke commented Jan 6, 2025

@Hosuke let's prep this for merge. remove enosys v3, add back union of flare data into final dex trades, etc.

we will revisit enosys v3 in a follow up PR when ready

Updated, but the unioned final dex trades may be too large to run in CI.

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting it merge ready. yes, CI cluster is struggling on dex builds on both cluster sizes (bigger machines/less nodes, smaller machines, more nodes). we will need to continue experimenting with sizing. in the meantime, we should consider forcing CI to filter dex_base_trades on a hardcoded date, see it run through, then revert commit.

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jan 6, 2025
@jeff-dude jeff-dude merged commit 37d914e into duneanalytics:main Jan 7, 2025
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants