Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new chainswap deployer to spellbook #6909

Merged

Conversation

whalehunting
Copy link
Contributor

Adds 0x686c0072dF3Df7A13ef666a3b661803a48558A90 as an additional deployer to ChainSwap's spellbook

@whalehunting whalehunting marked this pull request as ready for review October 8, 2024 17:06
@dune-eng
Copy link

dune-eng commented Oct 8, 2024

Workflow run id 11240281418 approved.

@dune-eng
Copy link

dune-eng commented Oct 8, 2024

Workflow run id 11240281838 approved.

@dune-eng
Copy link

dune-eng commented Oct 8, 2024

Workflow run id 11240283268 approved.

@dune-eng
Copy link

dune-eng commented Oct 8, 2024

Workflow run id 11240283258 approved.

@0xRobin 0xRobin self-assigned this Oct 14, 2024
@0xRobin 0xRobin added the WIP work in progress label Oct 14, 2024
@0xRobin
Copy link
Collaborator

0xRobin commented Oct 14, 2024

@whalehunting, the CI is failing on a uniqueness error.
Can you investigate this?

The last PR for these models did run and test successfully in the CI https://github.com/duneanalytics/spellbook/actions/runs/10792660335/job/29932804281

@dune-eng
Copy link

Workflow run id 11340706701 approved.

@dune-eng
Copy link

Workflow run id 11340706940 approved.

@whalehunting
Copy link
Contributor Author

@whalehunting, the CI is failing on a uniqueness error. Can you investigate this?

The last PR for these models did run and test successfully in the CI https://github.com/duneanalytics/spellbook/actions/runs/10792660335/job/29932804281

Seems to happen because the new router handles fees different (sending both eth + erc20s to the fee address). will think of a solution and implement it once i find the time. thanks for the ping!

@0xBoxer
Copy link
Collaborator

0xBoxer commented Oct 23, 2024

Due to a dbt version change, you need to merge main into your branch before the Github action runner runs successfully again.

@0xRobin 0xRobin marked this pull request as draft October 28, 2024 08:10
@jeff-dude
Copy link
Member

this PR and #7075 appear to be doing the same thing, but a different deployer address assigned?

can we coordinate the changes and get into one PR?

with that in mind, i'm closing #7075 with hope of pulling in changes here

@jeff-dude jeff-dude added the dbt: daily covers the Daily dbt subproject label Oct 31, 2024
@whalehunting whalehunting marked this pull request as ready for review December 1, 2024 16:55
@whalehunting
Copy link
Contributor Author

@jeff-dude applied changes from #7075 in this one, can ignore the other PR

@jeff-dude
Copy link
Member

@jeff-dude applied changes from #7075 in this one, can ignore the other PR

noted, will ignore other one and wait for your word here 🙏

@whalehunting
Copy link
Contributor Author

@jeff-dude @0xRobin tests are passing, ready for final review 🫡
this team has been waiting for a long time for this (my bad), would appreciate if we can merge it fast

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress labels Dec 3, 2024
@jeff-dude jeff-dude merged commit 70c36a9 into duneanalytics:main Dec 3, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: daily covers the Daily dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants