Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uniV3 basic lp info #5635

Closed
wants to merge 18 commits into from
Closed

feat: uniV3 basic lp info #5635

wants to merge 18 commits into from

Conversation

0xrusowsky
Copy link
Contributor

this PR will tackle:

in order to ship a spell that tracks volumes served by liquidity managed by ALMs (active liquidity managers), it is essential to first have a snapshot of the historical liquidity on each pool.

As a first-time contributor, i take this PR as a test to start small and asses whether what i build breaks or not. So the spell dex.lps created in this PR doesn't necessarily need to make it to production, as that logic could be internalized inside the pipeline to get the data in alm.trades.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @Hosuke
❌ @0xrusowsky
You can retrigger this bot by commenting recheck in this Pull Request

@dune-eng
Copy link

Workflow run id 8364677702 approved.

@dune-eng
Copy link

Workflow run id 8364678030 approved.

@0xrusowsky
Copy link
Contributor Author

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

@0xrusowsky
Copy link
Contributor Author

recheck

@dune-eng
Copy link

Workflow run id 8364957725 approved.

@dune-eng
Copy link

Workflow run id 8364957900 approved.

@dune-eng
Copy link

Workflow run id 8365258693 approved.

@dune-eng
Copy link

Workflow run id 8365258836 approved.

@jeff-dude jeff-dude added the WIP work in progress label Mar 21, 2024
@Hosuke Hosuke self-assigned this Mar 22, 2024
@Hosuke
Copy link
Collaborator

Hosuke commented Mar 22, 2024

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

You can sign the CLA without quoting/replying to the bot message.

Hosuke
Hosuke reviewed Mar 22, 2024
View reviewed changes
macros/models/_sector/dex/uniswap_compatible_lp.sql Outdated
, b.amount1
, f.token0 AS token0_address
, f.token1 AS token1_address
, m.contract_address AS pool_address
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, m.contract_address AS pool_address
, b.contract_address AS pool_address

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
yesterday i had to do other stuff, but will continue working on this during this afternoon and next week

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, if you have any problem please feel free to tag me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for your support!

@dune-eng
Copy link

Workflow run id 8449757355 approved.

@dune-eng
Copy link

Workflow run id 8449757149 approved.

@dune-eng
Copy link

Workflow run id 8449917957 approved.

@dune-eng
Copy link

Workflow run id 8449918218 approved.

@dune-eng
Copy link

Workflow run id 8449928650 approved.

@dune-eng
Copy link

Workflow run id 8449928853 approved.

@dune-eng
Copy link

Workflow run id 8450259767 approved.

@dune-eng
Copy link

Workflow run id 8450259694 approved.

@dune-eng
Copy link

Workflow run id 8450938673 approved.

@dune-eng
Copy link

Workflow run id 8451051617 approved.

@dune-eng
Copy link

Workflow run id 8451051456 approved.

@dune-eng
Copy link

Workflow run id 8451195679 approved.

@dune-eng
Copy link

Workflow run id 8451195873 approved.

@dune-eng
Copy link

Workflow run id 8451326769 approved.

@dune-eng
Copy link

Workflow run id 8451327012 approved.

@dune-eng
Copy link

Workflow run id 8453283281 approved.

@dune-eng
Copy link

Workflow run id 8453283690 approved.

@Hosuke
Copy link
Collaborator

Hosuke commented Mar 28, 2024

Also please sign the CLA, thank you @0xrusowsky

@0xrusowsky
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@0xrusowsky
Copy link
Contributor Author

recheck

@0xrusowsky
Copy link
Contributor Author

@Hosuke shouldn't this work?

@Hosuke
Copy link
Collaborator

Hosuke commented Mar 28, 2024 •
edited
Loading

Not sure why CLA check is failed.
Do you have any idea? @jeff-dude

@Hosuke Hosuke added help wanted Extra attention is needed ready-for-review this PR development is complete, please review and removed WIP work in progress labels Mar 28, 2024
@jeff-dude
Copy link
Member

recheck

@jeff-dude jeff-dude marked this pull request as ready for review March 28, 2024 13:01
@jeff-dude
Copy link
Member

not 100% sure honestly. i'd say try one more time copy/paste the words exactly without quoting anything. then don't comment recheck, see if it works on it's own.

if not, maybe close the PR and start fresh with new PR, comment again with just the sentence

@Hosuke Hosuke added WIP work in progress and removed help wanted Extra attention is needed ready-for-review this PR development is complete, please review labels Mar 29, 2024
@0xrusowsky 0xrusowsky closed this Apr 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hosuke Hosuke Hosuke left review comments

Assignees

@Hosuke Hosuke

Labels
WIP work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xrusowsky @dune-eng @Hosuke @jeff-dude