Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs to use {{this}} format for incremental #3341

Closed
wants to merge 18 commits into from
Closed

needs to use {{this}} format for incremental #3341

Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
dffb01f
needs to use {{this}} format for incremental
andrewhong5297 May 14, 2023
bebf854
should always be next day only
andrewhong5297 May 14, 2023
3945b01
Add uniqueness test
Hosuke May 15, 2023
7afffa3
keep block_slot
andrewhong5297 May 16, 2023
18838b7
Merge branch 'solana_daily_balances_fix' of https://github.com/dunean…
andrewhong5297 May 16, 2023
555b657
Merge branch 'main' into solana_daily_balances_fix
Hosuke May 17, 2023
5ff9b39
test 30
andrewhong5297 May 20, 2023
710f461
Try to fix the incremental merge checking bug
Hosuke May 20, 2023
99c8b33
Merge branch 'main' into solana_daily_balances_fix
Hosuke May 20, 2023
0464737
Merge branch 'main' into solana_daily_balances_fix
Hosuke May 23, 2023
53e7fed
remove 30 day limit
andrewhong5297 May 23, 2023
863f146
Merge branch 'main' into solana_daily_balances_fix
jeff-dude May 23, 2023
f85eaa2
add space
andrewhong5297 May 23, 2023
9b83a82
Add not_null tests
Hosuke May 24, 2023
b1870e5
Merge branch 'main' into solana_daily_balances_fix
jeff-dude May 25, 2023
f0fff46
Merge branch 'main' into solana_daily_balances_fix
Hosuke May 26, 2023
7d38cf0
Remove not_null test for latest_balance
Hosuke May 27, 2023
28654d7
Merge branch 'main' into solana_daily_balances_fix
Hosuke May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/solana_utils/solana_utils_daily_balances.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ WITH
FROM {{ source('solana','account_activity') }}
WHERE tx_success
{% if is_incremental() %}
AND block_time >= date_trunc("day", now() - interval '1 day')
AND block_time > (SELECT max(day) FROM {{this}})
Copy link
Collaborator

@0xRobin 0xRobin May 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use >= here to not drop later incremental updates from the same day?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since day is derived from date_trunc(...), it represents the lower bound of the time, I think > will include all events in that date after UTC 00:00.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to update on same day, only next day. To prevent duplicates.

There is the edge case of missing an address if their balance changes later that day but not the next day.

But ignoring that case for now!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah @Hosuke you're right! I was confused but indeed because we compare block_time with the day timestamp this works and there's no real difference between > and >=. 👍

{% endif %}
)

Expand Down