Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --no-delete option, resolves #224 #333

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

ramgp
Copy link
Contributor

@ramgp ramgp commented Mar 23, 2024

The user feedback is displayed in the header, I tried to make so that it disappears automatically after some time, but it seems to only update after some other action like moving in the list

Please let me know if this is good enough or if some other approach is preferred

Resolves #224.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 89.96%. Comparing base (58ad4d3) to head (d7d5022).

Files Patch % Lines
cmd/gdu/app/app.go 0.00% 3 Missing and 1 partial ⚠️
tui/tui.go 75.00% 3 Missing and 1 partial ⚠️
tui/show.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   90.02%   89.96%   -0.07%     
==========================================
  Files          32       32              
  Lines        3469     3497      +28     
==========================================
+ Hits         3123     3146      +23     
- Misses        279      283       +4     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramgp ramgp changed the title feat: add --no-delete option, resolves #325 feat: add --no-delete option, resolves #224 Mar 23, 2024
@dundee
Copy link
Owner

dundee commented Mar 24, 2024

The ui code needs to be called inside ui.app.QueueUpdateDraw(func() { to handle concurrency properly. See https://github.com/rivo/tview/wiki/Concurrency#actions-in-goroutines for more details.

I will add few improvements/fixes to your PR.

@dundee dundee merged commit d511c55 into dundee:master Mar 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: commandline switch to disable file deletion
2 participants