Skip to content

Commit

Permalink
feat: correct message when calculating stats for non-interactive mode
Browse files Browse the repository at this point in the history
  • Loading branch information
dundee committed Feb 11, 2024
1 parent d6554a3 commit 28acea9
Showing 1 changed file with 25 additions and 8 deletions.
33 changes: 25 additions & 8 deletions stdout/stdout.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,17 @@ func (ui *UI) ListDevices(getter device.DevicesInfoGetter) error {
// AnalyzePath analyzes recursively disk usage in given path
func (ui *UI) AnalyzePath(path string, _ fs.Item) error {
var (
dir fs.Item
wait sync.WaitGroup
dir fs.Item
wait sync.WaitGroup
updateStatsDone chan struct{}
)
updateStatsDone = make(chan struct{}, 1)

if ui.ShowProgress {
wait.Add(1)
go func() {
defer wait.Done()
ui.updateProgress()
ui.updateProgress(updateStatsDone)
}()
}

Expand All @@ -151,6 +153,7 @@ func (ui *UI) AnalyzePath(path string, _ fs.Item) error {
defer wait.Done()
dir = ui.Analyzer.AnalyzeDir(path, ui.CreateIgnoreFunc(), ui.ConstGC)
dir.UpdateStats(make(fs.HardLinkedItems, 10))
updateStatsDone <- struct{}{}
}()

wait.Wait()
Expand Down Expand Up @@ -322,14 +325,14 @@ func (ui *UI) showReadingProgress(doneChan chan struct{}) {
}
}

func (ui *UI) updateProgress() {
func (ui *UI) updateProgress(updateStatsDone <-chan struct{}) {
emptyRow := "\r"
for j := 0; j < 100; j++ {
emptyRow += " "
}

progressChan := ui.Analyzer.GetProgressChan()
doneChan := ui.Analyzer.GetDone()
analysisDoneChan := ui.Analyzer.GetDone()

var progress common.CurrentProgress

Expand All @@ -339,9 +342,23 @@ func (ui *UI) updateProgress() {

select {
case progress = <-progressChan:
case <-doneChan:
fmt.Fprint(ui.output, "\r")
return
case <-analysisDoneChan:
for {
fmt.Fprint(ui.output, emptyRow)
fmt.Fprintf(ui.output, "\r %s ", string(progressRunes[i]))
fmt.Fprint(ui.output, "Calculating disk usage...")
time.Sleep(100 * time.Millisecond)
i++
i %= 10

select {
case <-updateStatsDone:
fmt.Fprint(ui.output, emptyRow)
fmt.Fprint(ui.output, "\r")
return
default:

Check warning on line 359 in stdout/stdout.go

View check run for this annotation

Codecov / codecov/patch

stdout/stdout.go#L359

Added line #L359 was not covered by tests
}
}
}

fmt.Fprintf(ui.output, "\r %s ", string(progressRunes[i]))
Expand Down

0 comments on commit 28acea9

Please sign in to comment.