Abe integration #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dulalsaurab
reviewed
Aug 8, 2023
A.cert
Outdated
There was a problem hiding this comment.
don't push the certificate or csr files
certs/create_default_certs.sh
Outdated
There was a problem hiding this comment.
let's have only one certificate creation script. Also, not sure if the default is the right choice of word.
debug/consumer.log
Outdated
debug/producer.log
Outdated
runner.sh
Outdated
There was a problem hiding this comment.
I suggest renaming this file to test-runner or something, else it can be misleading. Also, I think this should go inside the example directory or somewhere, not in the root.
| // auto cert = *loadCert(certPath); | ||
| // auto id = m_keyChain.getPib().getIdentity(cert.getIdentity()); | ||
| // auto key = id.getKey(cert.getKeyName()); | ||
| // m_keyChain.addCertificate(key, cert); |
| // [this, a] (auto&&...) { | ||
| // m_face.put(a); | ||
| // }, | ||
| // nullptr, |
tmp-storage/generator.py
Outdated
There was a problem hiding this comment.
why these changes? is this needed?
tmp-storage/main.py
Outdated
tmp-storage/main2.py
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.