Add missing types #968
Merged
Add missing types #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorp1
reviewed
Oct 7, 2024
andrejak
force-pushed
the
missing-types
branch
2 times, most recently
from
791398c to
c83324d
Compare
andrejak
commented
Oct 9, 2024
| @@ -11,6 +11,13 @@ export type AirlineInitiatedChangeAvailableAction = | |||
| | 'change' | |||
| | 'update' | |||
|
|
|||
| export interface TravelAgentTicket { | |||
There was a problem hiding this comment.
| @@ -66,7 +73,7 @@ export interface AirlineInitiatedChange { | |||
| * Change. This value will be present for Airline-Initiated changes that take | |||
| * some time to be processed. | |||
| */ | |||
| travel_agent_ticket: any | null | |||
| travel_agent_ticket: TravelAgentTicket | EmptyObject | null | |||
There was a problem hiding this comment.
The "EmptyObject" is copied from dashboard...
| cabin: OfferSliceSegmentPassengerCabin | null | ||
| } | ||
|
|
||
| export interface OfferSliceSegmentPassengerCabin { |
There was a problem hiding this comment.
| @@ -14,6 +14,43 @@ export interface ListOrderCancellationsParams extends PaginationMeta { | |||
| order_id?: string | |||
| } | |||
|
|
|||
| export interface OrderCancellationAirlineCredit { | |||
There was a problem hiding this comment.
| @@ -4,7 +4,7 @@ export interface OrderChange { | |||
| /** | |||
| * The price of this offer as a change to your existing order, excluding taxes | |||
| */ | |||
| change_total_amount: string | null | |||
| change_total_amount: string | |||
There was a problem hiding this comment.
| * Note that this data may differ from the airline's records if it was updated directly with the airline since the order was created. | ||
| * @xample "[email protected]" | ||
| */ | ||
| email: string |
There was a problem hiding this comment.
| /** | ||
| * The ISO 8601 datetime at which the Order was paid for, if at all | ||
| */ | ||
| paid_at: string | null |
There was a problem hiding this comment.
| stops: Array<Stop> | ||
| } | ||
|
|
||
| export interface Stop { |
There was a problem hiding this comment.
| * The list of passenger ids the document applies to | ||
| * @example ["pas_00009hj8USM7Ncg31cBCLL"] | ||
| */ | ||
| passenger_ids: string[] |
There was a problem hiding this comment.
| * | ||
| * @example "2020-04-11T15:48:11Z" | ||
| */ | ||
| synced_at: string |
There was a problem hiding this comment.
igorp1
previously approved these changes
Oct 9, 2024
andrejak
commented
Oct 9, 2024
| @@ -450,7 +451,7 @@ export interface OfferSlice { | |||
| * - `"4"`: premium seating, additional legroom and recline. Situated in business class or higher. | |||
| * - `"5"`: deluxe seating, additional legroom and reclines to lie flat position. Situated in business class or higher. | |||
| */ | |||
| ngs_shelf: number | |||
| ngs_shelf: number | null | |||
There was a problem hiding this comment.
| @@ -151,17 +165,17 @@ export type OfferSliceConditions = FlightsConditions & { | |||
| /** | |||
| * Whether passengers are able to select a seat prior to check in. | |||
| */ | |||
| advance_seat_selection: boolean | |||
| advance_seat_selection: boolean | null | |||
There was a problem hiding this comment.
andrejak
force-pushed
the
missing-types
branch
from
e4672f4 to
6707f61
Compare
andrejak
force-pushed
the
missing-types
branch
2 times, most recently
from
aa74ee5 to
eb939c2
Compare
Update src/types/shared.ts Co-authored-by: Igor <[email protected]> Update src/types/shared.ts Co-authored-by: Igor <[email protected]>
andrejak
force-pushed
the
missing-types
branch
from
eb939c2 to
72ce238
Compare
jekku
reviewed
Oct 10, 2024
|
|
||
| /** | ||
| * Whether passengers are given access to a fast track lane during check in. | ||
| */ | ||
| priority_check_in: boolean | ||
| priority_check_in: boolean | null |
There was a problem hiding this comment.
jekku
reviewed
Oct 10, 2024
|
|
||
| /** | ||
| * Whether passengers are given preferential boarding over others passengers in their cabin. | ||
| */ | ||
| priority_boarding: boolean | ||
| priority_boarding: boolean | null |
There was a problem hiding this comment.
jekku
reviewed
Oct 10, 2024
| @@ -597,7 +599,10 @@ export const mockOnHoldOrders: Order[] = [ | |||
| iata_code: 'MIA', | |||
| }, | |||
| }, | |||
| conditions: { change_before_departure: null }, | |||
| conditions: { | |||
There was a problem hiding this comment.
jekku
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
We started using the types from our client library in our dashboard and in doing so identified a few things we can improve and other bits that need fixing. This addresses the gaps we found.
Please see the comments for links to documentation to compare with.