fix: update airlines types to better match schema #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejak
force-pushed
the
conditions-of-carriage
branch
3 times, most recently
from
e285102 to
a860eb1
Compare
andrejak
force-pushed
the
conditions-of-carriage
branch
from
a860eb1 to
b9f23cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing conditions of carriage and also noticed iata_code might not be present: https://duffel.com/docs/api/airlines/schema
In the repo we're a bit inconsistent with nullable vs optional properties but let me know if you'd prefer me to keep the existing way in this file.