Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistently use relative imports for types #810

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: consistently use relative imports for types #810

merged 1 commit into from
Oct 13, 2023

Conversation

andrejak
Copy link
Contributor

We use relative imports for types in most of the codebase, apart from these few instances. This PR makes that more consistent and should help with some recently seen TS issues.

@andrejak andrejak marked this pull request as ready for review October 13, 2023 07:14
@andrejak andrejak requested a review from a team as a code owner October 13, 2023 07:14
igorp1
igorp1 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@igorp1 igorp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@andrejak andrejak merged commit a95cf39 into main Oct 13, 2023
1 check passed
@andrejak andrejak deleted the relative-imports-for-types branch October 13, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorp1 igorp1 igorp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrejak @igorp1