Use relative paths for the Client more consistently #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorp1
approved these changes
Oct 11, 2023
|
Amazing thanks for sorting so fast! I’ve not had a chance to test yet, but after looking at your commit I noticed only the Client imports were repaired, I think there were a few other rouge imports in my Issue which were causing problems. Apologies if I didn’t make that clear, I was working overtime undercaffeinated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few Client imports that weren't using relative paths to match the rest, which will hopefully help resolve #794.
I also updated the version of the package in the example. I wasn't actually seeing this issue in the example, but I think it makes sense to keep it up to date.