Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Release with CI via git tag #289

Merged
merged 2 commits into from
Nov 18, 2024
Merged

ci: Release with CI via git tag #289

merged 2 commits into from
Nov 18, 2024

Conversation

jakoschiko
Copy link
Collaborator

This workflow is similar to the version in repository imap-codec, but simpler because there is only a single crate that needs to be released.

Closes #282

@jakoschiko jakoschiko requested a review from duesee November 12, 2024 23:40
@jakoschiko jakoschiko self-assigned this Nov 12, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11898486923

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.757%
Totals Coverage Status
Change from base Build 11898320597: 0.0%
Covered Lines: 1021
Relevant Lines: 1219
💛 - Coveralls

@jakoschiko
Copy link
Collaborator Author

We probably need to wait for #285. After that we can test the CI and then remove the --dry-run. And finally, @duesee, you would need to add a secrets.CARGO_REGISTRY_TOKEN to the repo.

@jakoschiko jakoschiko force-pushed the jakoschiko_release-with-ci branch from d83539a to b8b0294 Compare November 18, 2024 17:58
duesee
duesee approved these changes Nov 18, 2024
View reviewed changes
Copy link
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect (w/o the --dry-run :-))

@duesee duesee force-pushed the jakoschiko_release-with-ci branch from 54c0997 to fe9bb42 Compare November 18, 2024 18:13
@duesee duesee enabled auto-merge (squash) November 18, 2024 18:13
@jakoschiko jakoschiko mentioned this pull request Nov 18, 2024
Closed
@duesee duesee merged commit 8fd5322 into main Nov 18, 2024
8 checks passed
@duesee duesee deleted the jakoschiko_release-with-ci branch November 18, 2024 18:20
@duesee duesee mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees

@jakoschiko jakoschiko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release with CI via git tag
3 participants
@jakoschiko @coveralls @duesee