-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve code examples #397
Conversation
Also see #394 |
Hehe, I was just about to merge because I overlooked https://github.com/duesee/imap-codec/pull/397/files#diff-cfcb5beb66760b7d974ea036d027714665a3c57f72ca940df6dcdd3e138a1d69R24-R32 :D Good that we have a CI :-) I think it should be enough to remove this? Same with https://github.com/duesee/imap-codec/pull/397/files#diff-cfcb5beb66760b7d974ea036d027714665a3c57f72ca940df6dcdd3e138a1d69R65-R72? Maybe also toss a |
Whoops (○´・д・)ノ my bad, I didn't use //! # use imap_codec::{
//! # encode::Encoder,
//! # imap_types::{
//! # core::Text,
//! # response::{Code, Greeting, GreetingKind},
//! # },
//! # GreetingCodec,
//! # };
I originally wanted to write a separate section to specifically explain how to use imap-types, but I thought it would be better to write it as a comment in the code, so I deleted your previous code. Now, |
Pull Request Test Coverage Report for Build 7130307555
💛 - Coveralls |
Thanks! :-) |
Oh, btw @coalooball: Was this your first PR on GitHub? I feel honored! :D Congratz 🎉 |
Haha, this is my first PR, and I'm pretty excited about it. Thank you for your blessings, @duesee! I hope I can become as awesome as you, contributing real-code PRs to |
See #393