Fix frozen Preferences About screen #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
commented
Dec 30, 2024
| @@ -33,52 +33,37 @@ extension Preferences { | |||
|
|
|||
| var body: some View { | |||
| PreferencePane { | |||
| GeometryReader { geometry in | |||
There was a problem hiding this comment.
Having the GeometryReader causes the problem. Seems specific to Xcode 16, as a previous build with the same implementation doesn't have this issue.
jotaemepereira
approved these changes
Dec 31, 2024
|
Failing tests are malicious site protection related, likely due to BE as ship review builds for that feature is also not working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1209057693918519/f
Tech Design URL:
CC:
Description:
Fixes Preferences About screen not accepting inputs
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation