include config dir clearance in clean-app script #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
reviewed
Dec 10, 2024
clean-app.sh
Outdated
| @@ -8,27 +8,32 @@ delete_data() { | |||
| if defaults read "${bundle_id}" &>/dev/null; then | |||
| defaults delete "${bundle_id}" | |||
| fi | |||
| rm -rf "${HOME}/Library/Containers/${bundle_id}/Data" | |||
| rm -r "${HOME}/Library/Containers/${bundle_id}/Data" | |||
There was a problem hiding this comment.
Why are we removing -f? This will break the script when the directory doesn't exist.
There was a problem hiding this comment.
well, it does for me;
but it does report a missing dir status instead if you run it twice
There was a problem hiding this comment.
Sorry about that, the script actually goes on (we’re not using set -e here, but displays an error). Would be great to have it handled gracefully if we’re skipping -f. Thanks for updating it.
ayoy
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208943073994046/f
Description:
~/Library/Group\ Containers/*.com.duckduckgo.macos.browser.app-configuration.debug/*path to clear by the./clean-app.shscriptOptional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation