-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Privacy Pro translations #3656
Merged
+22,983
−5,529
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3157ba9
Add module for Subsctiption UserText strings
miasma13 97fe5a5
Support translations for SubscriptionUI package
miasma13 1dbc9c9
Add support for localising NetworkProtectionUI
miasma13 3cbdff4
Generate localizcles for NetworkProtectionUI
miasma13 51437d6
Extract missing VPN strings
miasma13 59cd892
Remove dead xcstrings reference from the project file.
samsymons f1cf08f
Fix how we build subscription renewal or expiry caption to better sup…
miasma13 f56912a
Import translations
miasma13 d3132d8
Make privacy pro alerts localizable
miasma13 702d708
Localize UserText+NetworkProtection
miasma13 e410efa
Split VPN copy used by main app and shared with VPN targets
miasma13 fbcdef2
Add Localizables for DuckDuckGoVPN target
miasma13 0b02e4b
Fix duplicated string identifiers
miasma13 b0ce5ab
Localize Notifications target
miasma13 bc7af06
Fix duplicated string ids
miasma13 7034f65
Update the export script
miasma13 7a4a930
Revert translating infoplist
miasma13 dde59d6
Merge branch 'release/1.118.0' into michal/update-pp-translations
miasma13 3206da5
Fix whitespace
miasma13 f6bc31a
Import translations
miasma13 b8689ca
Add localizable strings exclude for sandbox-test-tool
miasma13 4752b97
Remove stale strings
miasma13 9a67373
Make DBP strings localizable
miasma13 36435d5
Add en-US to module string catalogs to mitigate potential issue with …
miasma13 d30b5d5
Import PIR translations
miasma13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix duplicated string ids
commit bc7af061cafa2b7a34bdc089f47879fa2845badb
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is strange here - it's a Network Protection string, but in a DBP file, with a DBP prefix. At the end of the day it should work as intended, but caught me off guard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was a copy paste issue and fixed the string ID but completely missed the variable name. I see it is not used anywhere, maybe it was a placeholder to setup localizations. Since they are not used anywhere I will proceed and delete it.