Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hiding toolbars on full screen #3652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jotaemepereira
Copy link
Collaborator

@jotaemepereira jotaemepereira commented Dec 9, 2024

Task/Issue URL: https://app.asana.com/0/0/1208939873445197/f
Tech Design URL:
CC:

Description:
Adds a setting that hides the tabs and bookmarks bar toolbars when on full-screen mode.

Steps to test this PR:

  1. Go to Settings → Appearance → Check 'Remove Tabs and Bookmarks Bar toolbars on Full Screen'
  2. Open a site
  3. Enter full screen mode
  4. The tabs toolbar and the bookmarks bar should be hidden automatically
  5. When the user exits full screen mode, it should restore both toolbars
  6. Disable the feature, both the bookmarks bar and the tabs toolbar should be visible on full screen

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 3485b2e

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant