Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208674332470432/f
Tech Design URL:
CC:
Description:
Refactors Overlay Pixels to use WebKit KVO and backForward lists for improved reliability
Steps to test this PR:
m_mac_duckplayer_youtube_overlay_navigation_back
pixel firesm_mac_duckplayer_youtube_overlay_navigation_refresh
pixel firesm_mac_duckplayer_youtube_overlay_navigation_within-youtube
m_mac_duckplayer_youtube_overlay_navigation_outside-youtube
firesSmoke test going to/from videos and confirm pixels fire as expected.
Demo: