Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Overlay Pixels #3644

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Refactor Overlay Pixels #3644

merged 3 commits into from
Dec 9, 2024

Conversation

afterxleep
Copy link
Contributor

@afterxleep afterxleep commented Dec 6, 2024

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208674332470432/f
Tech Design URL:
CC:

Description:
Refactors Overlay Pixels to use WebKit KVO and backForward lists for improved reliability

Steps to test this PR:

  1. Filter the console messages for "PixelKit."
  2. Go to Youtube.com
  3. Search for MKBHD
  4. Select a video
  5. Hit Back
  6. Confirm m_mac_duckplayer_youtube_overlay_navigation_back pixel fires
  7. Select another video
  8. Hit Refresh
  9. Confirm m_mac_duckplayer_youtube_overlay_navigation_refreshpixel fires
  10. Navigate to other Youtube video suggestion
  11. Confirm m_mac_duckplayer_youtube_overlay_navigation_within-youtube
  12. Visit another website (i.e. example.com)
  13. Confirm m_mac_duckplayer_youtube_overlay_navigation_outside-youtube fires

Smoke test going to/from videos and confirm pixels fire as expected.

Demo:
12-06 at 19 35

Refactors Overlay Pixels to use WebKit KVO and backForward lists for improved reliablity
@afterxleep afterxleep requested a review from ayoy December 6, 2024 18:41
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested this extensively and correct pixels are being fired consistently. Leaving minor comments but I believe it's good to go as is.

@afterxleep afterxleep merged commit 8a4f89e into main Dec 9, 2024
19 of 20 checks passed
@afterxleep afterxleep deleted the daniel/overlay-refactor branch December 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants