Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filterlist exceptions in CPM #3642

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

muodov
Copy link
Member

@muodov muodov commented Dec 6, 2024

Task/Issue URL: https://app.asana.com/0/1201844467387842/1208922008756199/f
Tech Design URL: https://app.asana.com/0/1201844467387842/1208922009067412/f
CC:

Description:
Add a possibility to disable easylist without disabling the whole CPM feature (per domain)

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. enable CPM
  2. In debug menu, override the remote config URL to https://jsonblob.com/api/jsonBlob/1319667949929422848
  3. Open https://store.serif.com/en-gb/sign-in/?r=https%3A%2F%2Faffinity.serif.com%2Fen-gb%2Faffinity-beta-program%2F
  4. Dismiss the cookie popup manually
  5. Verify that you can type in the input fields
  6. Verify that there's no CPM entry in the privacy dashboard
  7. In debug menu, override the remote config URL to https://jsonblob.com/api/jsonBlob/1319668303622496256
  8. Use the Fire button, and load the test page again
  9. Verify that cookie popup is NOT visible, and the the input fields are NOT usable, and there is a CPM notification in the Privacy Dashboard and the address bar

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Dec 17, 2024
@muodov muodov requested a review from mallexxx December 18, 2024 17:47
@github-actions github-actions bot removed the stale label Dec 19, 2024
@muodov
Copy link
Member Author

muodov commented Dec 20, 2024

@mallexxx FYI I've added the test steps in description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants