Move HTML NTP into a local package #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ML NTP is available
jotaemepereira
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
@ayoy This is looking great. I’ve ran different tests around NTP and it is working as expected 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208909283620583/f
CC: @mallexxx
Description:
This change does not add any new feature and it only reorganizes the code adding NewTabPage local package
that contains all HTML NTP code that is independent of the rest of the app. In order to achieve that,
additional local packages were created: WebKitExtensions and Utilities, and a few more extension classes
were moved from the main app target to AppKitExtensions.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation