BSK update for iOS system credential provider support #3628
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 7, 2024
Task/Issue URL: iOS PR: duckduckgo/iOS#3658 macOS PR: duckduckgo/macos-browser#3628 What kind of version bump will this require?: Minor **Description**: Migrates secure vault DB file to shared storage, and migrates the vault keychain items to shared keychain on iOS for usage by its new credential provider extension
…provider # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: Tech Design URL: CC: **Description**: iOS QuickType support update
6 tasks
…provider # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
aataraxiaa
approved these changes
Dec 9, 2024
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 9, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1207512172220035/f iOS PR: duckduckgo/iOS#3699 macOS PR: duckduckgo/macos-browser#3628 What kind of version bump will this require?: Minor Description: Adds support for system level credential provider changes on iOS
…provider # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207512172220035/f
Tech Design URL:
CC:
Description:
Update to BSK due to changes for iOS
Steps to test this PR:
mainand save some credentialsv4migration as all keychain items should remain onv3<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGElabel (particularly if it's a draft)If it's pending Product Review/PFR, please add the
Pending Product Reviewlabel.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation