-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Next Steps cards on HTML New Tab Page #3621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
We discussed that the for add to dock we will add confirmation UI later on C-S-S.
|
||
@MainActor | ||
func action(params: Any, original: WKScriptMessage) async throws -> Encodable? { | ||
guard let card: NewTabPageNextStepsCardsClient.Card = DecodableHelper.decode(from: params) else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just need let card: Card =
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right :) Let me add it in the next PR because I'm moving ALOT code around and would rather avoid conflicts
Task/Issue URL: https://app.asana.com/0/72649045549333/1208246350498752/f
Description:
This change adds Next Steps cards section on HTML New Tab Page. The change from native NTP
is that Next Steps section can't be controlled by the user.
Steps to test this PR:
General note - the view model wasn't changed so all the logic (e.g. cards randomization or hiding after 7 days) should work the same as on the native NTP.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation