Prevents app updates from stopping the VPN. #3608
Merged
+18
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
diegoreymendez
changed the title
diegoreymendez
requested review from
samsymons and
a team
and removed request for
samsymons and
a team
samsymons
approved these changes
Nov 28, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 28, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208865941226621/f iOS PR: duckduckgo/iOS#3639 macOS PR: duckduckgo/macos-browser#3608 What kind of version bump will this require?: Patch ## Description Removes a duplicated step from the tunnel stop logic that was causing some trouble in the logs.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Nov 28, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208865941226621/f BSK PR: duckduckgo/BrowserServicesKit#1102 macOS PR: duckduckgo/macos-browser#3608 ## Description Removes a duplicated step from the tunnel stop logic that was causing some trouble in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208865941226621/f
BSK PR: duckduckgo/BrowserServicesKit#1102
iOS PR: duckduckgo/iOS#3639
Description
Changes how the tunnel is restarted on app update so that it won't fail to start again..
Testing
The same steps provided here can be used to validate the original issue in
main.Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation