Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription oauth api v2 #3580

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

federicocappelli
Copy link
Member

@federicocappelli federicocappelli commented Nov 21, 2024

Task/Issue URL: https://app.asana.com/0/1205842942115003/1207991044706236/f
Tech Design URL: https://app.asana.com/0/1205842942115003/1207991044706232/f
CC: @miasma13

Description:

This PR introduces the use of OAuth V2 authentication in Privacy Pro Subscription.
The code changes are comprehensive due to the paradigm changes between the old access token lifecycle and the new JWT lifecycle.
The Subscription UI and UX should be unchanged.

Steps to test this PR:

Test all Privacy Pro Subscription features and UX, more details here


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@federicocappelli federicocappelli changed the title Fcappelli/subscription oauth api v2 Subscription oauth api v2 Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Fails
🚫 Please, don't forget to add a link to the internal task
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against b21b30d

# Conflicts:
#	DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewController.swift
# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/Application/AppDelegate.swift
#	DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift
#	DuckDuckGo/Subscription/SubscriptionManager+StandardConfiguration.swift
#	DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewController.swift
#	DuckDuckGo/UnifiedFeedbackForm/UnifiedFeedbackFormViewModel.swift
#	LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/SubscriptionDebugMenu.swift
#	LocalPackages/SubscriptionUI/Sources/SubscriptionUI/Preferences/PreferencesSubscriptionModel.swift
#	UnitTests/Freemium/DBP/Experiment/FreemiumDBPPixelExperimentManagingTests.swift
#	UnitTests/Freemium/DBP/FreemiumDBPFeatureTests.swift
#	UnitTests/Menus/MoreOptionsMenuTests.swift
#	UnitTests/Subscription/SubscriptionAppStoreRestorerTests.swift
#	UnitTests/Subscription/SubscriptionPagesUseSubscriptionFeatureForStripeTests.swift
#	UnitTests/Subscription/SubscriptionPagesUseSubscriptionFeatureTests.swift
#	UnitTests/UnifiedFeedbackForm/UnifiedFeedbackFormViewModelTests.swift
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	UnitTests/UnifiedFeedbackForm/UnifiedFeedbackFormViewModelTests.swift
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	LocalPackages/NewTabPage/Sources/NewTabPage/Favorites/NewTabPageFavoritesClient.swift
#	LocalPackages/NewTabPage/Sources/NewTabPage/NextStepsCards/NewTabPageNextStepsCardsClient.swift
#	LocalPackages/NewTabPage/Sources/NewTabPage/PrivacyStats/NewTabPagePrivacyStatsClient.swift
@federicocappelli federicocappelli marked this pull request as ready for review December 12, 2024 17:43
@THISISDINOSAUR
Copy link
Contributor

I'm still testing, but in case I run out of time before I'm out for the holidays want to report I'm struggling to get PIR working on this branch, initial scans never get off the starting block. Login item issues are common when flipping between multiple builds though, so it doesn't definitely mean it's broken. Is it working for you?

Screenshot 2024-12-13 at 4 15 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants