Fix DBP test case #3554
Fix DBP test case #3554
Conversation
# Conflicts: # LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Resources/fake.verecor.com.json
quanganhdo
changed the base branch from
main
to
anh/pir/show-optoutattemptdb
| @@ -389,6 +396,8 @@ final class DataBrokerProfileQueryOperationManagerTests: XCTestCase { | |||
| XCTAssertTrue(mockDatabase.optOutEvents.contains(where: { $0.type == .optOutConfirmed })) | |||
| XCTAssertTrue(mockDatabase.wasUpdateRemoveDateCalled) | |||
| XCTAssertNotNil(mockDatabase.extractedProfileRemovedDate) | |||
| XCTAssertTrue(mockDatabase.wasUpdatedPreferredRunDateForOptOutCalled) | |||
There was a problem hiding this comment.
This assertion disappeared some time in the last year. Added it back to check for the correct preferred run date.
There was a problem hiding this comment.
I'm worried this was removed deliberately. I do remember at one point the deliberate choice to keep doing certain operations for old data even when a user had changed their details.
There was a problem hiding this comment.
@jotaemepereira / @Bunn Do you have any context on this?
There was a problem hiding this comment.
@quanganhdo, I do not have the full context of the change; I need to dig deeper. What @THISISDINOSAUR is mentioning is true.
When a user changes their profile and there are current opt-outs in progress for the old profile, we will:
- Not scan for new matches in the old profile
- In-progress matches for the old profile should be driven to completion (opt-out and then confirmation)
I do not know if this helps; ping me on MM if you need more assistance.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
Task/Issue URL: https://app.asana.com/0/72649045549333/1208757448779624/f
Tech Design URL:
CC:
Description:
Fixes a test case to ensure when a profile is removed, scheduled opt-out request is cancelled.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation