Fix bug where bookmarks bar prompt does not hide bar #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
changed the title
samsymons
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
The steps listed worked for me, so I'll approve this, though the UX feels weird in that the bookmarks bar prompt doesn't appear on first bookmark, but rather shortly after the first bookmark. Since this PR hasn't affected that logic, I'll approve this and take the UX discussion elsewhere - thanks!
jotaemepereira
deleted the
juan/fix-show-bookmarks-popover-hide-not-working
branch
samsymons
added a commit
that referenced
this pull request
Nov 21, 2024
…g-error # By Anka (5) and others # Via GitHub (5) and Dominik Kapusta (1) * main: (28 commits) Add attemptCount and maxAttempts to broker config (#3533) Hide continue setup cards after 1 week (#3471) Add expectation when checking email text field value (#3572) [macos] adding support for message bridge (#3558) Update PIR test runner (#3570) Add support for controlling sections visibility on HTML New Tab Page (#3551) Bump version to 1.115.0 (311) macOS 13/14 UI test compilation fix (#3569) macOS 13/14 UI test compilation fix (#3569) Fix bug where bookmarks bar prompt does not hide bar (#3553) Add OS version to download fail pixel (#3568) Remove get_tasks_in_last_internal_release (#3566) Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208767244367092/f
Tech Design URL:
CC:
Description:
We currently have a bug when the ’Show Bookmarks Bar` prompt is shown, if the user selects the hide option. The bar is visible.
The problem is that when showing the prompt, we update the visibility of the bookmarks bar but without updating its value, then when the user selects to hide or dismiss the prompt, given that the old value is false and the new values is false, the subscriber discards the new value and does not update the UI.
Removing the
removeDuplicates()fixes the issue. I do not think there are problems removing that call, updating the visibility is something that happens on user interaction, we will have an ‘extra’ call if the user taps againg the same setting but I do not forsee a concern (open to opinions).Steps to test this PR:
./clean-app.sh debug)Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation