Add support for controlling sections visibility on HTML New Tab Page #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee77f47.
…owserTabViewController initializer
ayoy
requested review from
SabrinaTardio
and removed request for
SabrinaTardio
SabrinaTardio
approved these changes
Nov 19, 2024
| @@ -34,6 +35,7 @@ final class MainViewController: NSViewController { | |||
| let findInPageViewController: FindInPageViewController | |||
| let fireViewController: FireViewController | |||
| let bookmarksBarViewController: BookmarksBarViewController | |||
| let featureFlagger: FeatureFlagger | |||
There was a problem hiding this comment.
Is it actually used?
There was a problem hiding this comment.
Ah no, I mentioned it to you yesterday but forgot to remove it :) sorry and thanks for the reminder!
There was a problem hiding this comment.
Apologies. It actually is required because it's used in MainMenuActions.swift
samsymons
added a commit
that referenced
this pull request
Nov 21, 2024
…g-error # By Anka (5) and others # Via GitHub (5) and Dominik Kapusta (1) * main: (28 commits) Add attemptCount and maxAttempts to broker config (#3533) Hide continue setup cards after 1 week (#3471) Add expectation when checking email text field value (#3572) [macos] adding support for message bridge (#3558) Update PIR test runner (#3570) Add support for controlling sections visibility on HTML New Tab Page (#3551) Bump version to 1.115.0 (311) macOS 13/14 UI test compilation fix (#3569) macOS 13/14 UI test compilation fix (#3569) Fix bug where bookmarks bar prompt does not hide bar (#3553) Add OS version to download fail pixel (#3568) Remove get_tasks_in_last_internal_release (#3566) Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208644439480896/f
Tech Design URL: https://app.asana.com/0/0/1208763428292737/f
Description:
This change adds a separate webView to host HTML New Tab Page. It's got its own
User Content Controller and Navigation Delegate, loads only the NTP user script and
blocks navigations other than to the new tab page (i.e. all other URLs).
BrowserTabViewController logic is updated to swap regular webView with NTP webView
as needed to provide seamless navigation.
Another addition in this patch is the initial functionality of the HTML NTP which is
managing sections visibility (Favorites + Privacy Stats). Empty favorites and privacy stats
sets are hardcoded to verify that visibility settings work.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation