Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDG domain name check for fireproofing storage #3549

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Nov 14, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1204888209490841/f

Description:
Add DDG domain name check for fireproofing storage

Steps to test this PR:

  1. Go to a DDG domain website like https://duck.ai/ (which will redirect you to it) open the console and add something to the localStorage. localStorage.setItem('potatoKey', 'Potato Value');
  2. Check if it's saved by running console.log(localStorage.getItem('potatoKey')); in the console
  3. Click the fire button
  4. Go back to AI Chat and validate if the data is still there with the command from step 2

@Bunn Bunn requested a review from samsymons November 14, 2024 11:12
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@samsymons samsymons merged commit b6e6691 into main Nov 17, 2024
18 checks passed
@samsymons samsymons deleted the bunn/aichat/firestorage branch November 17, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants