Update opt out retry interval to every 5 days #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanganhdo
changed the base branch from
anh/pir/resubmit-opt-outs
to
anh/pir/timeline-events
quanganhdo
force-pushed
the
anh/pir/timeline-events
branch
from
e456339 to
ad9ce10
Compare
quanganhdo
force-pushed
the
anh/pir/retry-every-5-days
branch
from
328085e to
915219f
Compare
quanganhdo
force-pushed
the
anh/pir/timeline-events
branch
from
f3e3967 to
dfd97aa
Compare
quanganhdo
force-pushed
the
anh/pir/retry-every-5-days
branch
from
915219f to
f64f8cf
Compare
quanganhdo
force-pushed
the
anh/pir/retry-every-5-days
branch
from
f64f8cf to
f7a2402
Compare
quanganhdo
changed the base branch from
anh/pir/timeline-events
to
anh/pir/resubmit-opt-outs
|
@THISISDINOSAUR Should be good to go https://app.asana.com/0/0/1208768790402372/f if you have no other comments. |
Task/Issue URL: https://app.asana.com/0/72649045549333/1208768738130147/f Tech Design URL: CC: **Description**: Shows OptOutAttemptDB in DB Browser **Steps to test this PR**: 1. Check DB browser 2. You should be able to view OptOutAttemptDB contents <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Task/Issue URL: https://app.asana.com/0/1205591970852438/1208761697124514/f Tech Design URL: CC: **Description**: Workaround to deal with OptOutAttemptDB having one-to-one relationship with ExtractedProfileDB. The idea is to let subsequent attempts overwrite the previous one. Associated pixels should've already been fired, so no data loss. This would allow the opt-out operation to finish cleanly, add the right history events, and fire the correct pixels. **Steps to test this PR**: This is quite time consuming to verify. You may use this branch for sped up process: https://github.com/duckduckgo/macos-browser/tree/anh/pir/resubmit-opt-outs-pr-review 1. Go through the DBP flow 2. Move the system time forward so that DBP does another scan/opt-out passes 3. As opt-out retries are done, you should see attemptCount being incremented in the DB browser <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208741101628747/f
Tech Design URL:
CC:
Description:
Update retry interval from 10 days to 5 days.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation