Add attemptCount and maxAttempts to broker config #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Resources/fake.verecor.com.json
aataraxiaa
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Mostly looks good @quanganhdo, left a couple of suggestions.
...ataBrokerProtection/Sources/DataBrokerProtection/Database/DataBrokerProtectionDatabase.swift
Outdated
Show resolved
Hide resolved
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Show resolved
Hide resolved
...tection/Sources/DataBrokerProtection/Operations/DataBrokerProfileQueryOperationManager.swift
Outdated
Show resolved
Hide resolved
...kerProtection/Sources/DataBrokerProtection/Operations/OperationPreferredDateCalculator.swift
Outdated
Show resolved
Hide resolved
aataraxiaa
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Tested and LGTM! Thanks for making the suggested changes @quanganhdo 🚀
Task/Issue URL: https://app.asana.com/0/0/1208741101628747/f Tech Design URL: CC: **Description**: Update retry interval from 10 days to 5 days. **Steps to test this PR**: 1. CI passes <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
samsymons
added a commit
that referenced
this pull request
Nov 21, 2024
…g-error # By Anka (5) and others # Via GitHub (5) and Dominik Kapusta (1) * main: (28 commits) Add attemptCount and maxAttempts to broker config (#3533) Hide continue setup cards after 1 week (#3471) Add expectation when checking email text field value (#3572) [macos] adding support for message bridge (#3558) Update PIR test runner (#3570) Add support for controlling sections visibility on HTML New Tab Page (#3551) Bump version to 1.115.0 (311) macOS 13/14 UI test compilation fix (#3569) macOS 13/14 UI test compilation fix (#3569) Fix bug where bookmarks bar prompt does not hide bar (#3553) Add OS version to download fail pixel (#3568) Remove get_tasks_in_last_internal_release (#3566) Bump version to 1.115.0 (310) Update skip-release check Update fastlane plugin to 0.11.6 Bump ddg-apple-automation version for bugfix (#3565) PIR E2E tests GitHub actions (#3528) Update autoconsent to v11.5.0 (#3561) Bump version to 1.115.0 (309) Set marketing version to 1.115.0 ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208700893044577/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208663928051302/f
CC:
Description:
This implements the retry mechanism update portion of the TD.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation