Validate VPN errors before re-throwing them #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
diegoreymendez
approved these changes
Nov 1, 2024
…the-os # By Dax the Duck (3) and others # Via Dax the Duck (1) and others * main: Bump version to 1.112.0 (296) Marking latest Bitwarden versions as incompatible (#3492) Bump version to 1.112.0 (295) Update to subscription cookie (#3489) Bug Fix: Phishing Detection Dataset Discrepancies (#3440) Bump version to 1.112.0 (294) Fix crash when opening permission popover for NewTab page address bar (#3484) update UI test (#3469) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 3, 2024
**Required**: Task/Issue URL: https://app.asana.com/0/414709148257752/1208225499545869/f iOS PR: duckduckgo/iOS#3513 macOS PR: duckduckgo/macos-browser#3490 What kind of version bump will this require?: Major **Description**: This PR attempts to catch malformed errors before they get thrown to the OS. It also informs us when this happens.
…the-os # By Tom Strba # Via GitHub * main: Allowing users to delete suggestions (#3430) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
deleted the
sam/validate-errors-before-throwing-them-to-the-os
branch
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
# By Dax the Duck (5) and others # Via GitHub (4) and Michal Smaga (1) * main: (24 commits) Validate VPN errors before re-throwing them (#3490) Allowing users to delete suggestions (#3430) Bump version to 1.112.0 (296) Marking latest Bitwarden versions as incompatible (#3492) Bump version to 1.112.0 (295) Update to subscription cookie (#3489) Bug Fix: Phishing Detection Dataset Discrepancies (#3440) Bump version to 1.112.0 (294) Fix crash when opening permission popover for NewTab page address bar (#3484) Set version_check_wait_retry_limit to 1 (#3488) Refactor automatic update flow to use custom Sparkle user driver (#3274) Add to Dock - Update BSK version (#3479) Freemium PIR: Manual Removal Links (#3466) Fix Sync E2E tests (#3486) Fix crash on empty bookmarks html root element (#3482) update UI test (#3469) Update BSK with autofill 15.1.0 (#3480) Bump version to 1.112.0 (293) New tagline (#3401) add system info to webkit termination validation (#3473) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1208225499545869/f
Tech Design URL:
CC:
Description:
This PR updates the VPN to validate errors before throwing them to the OS.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation